fix: Update repartition processor names for KAFKA-9098 #3802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Kafka Streams introduced the ability to name repartition topics, the accompanying
Filter
,Source
andSink
processors continued to use the generated names. With the addition of KIP-307, users can now name every operator in a Streams DSL application. The repartitionFilter
,Source
, andSink
operators are internally generated and the users have no ability to name these operations.So if a user goes through and names every operation in their DSL application, when viewing a topology description they will still see some
KSTREAM-XXX-00000000N
names (if there is a repartition topic), which could be confusing.Now when users provide a name for the repartition topic Kafka Streams will name the processors for the repartition in the following manner:
repartition topic name =
my-aggregation-repartition
KSTREAM-FILTER-00000000N
->my-aggregation-repartition-filter
KSTREAM-SINK-00000000N
->my-aggregation-repartition-sink
KSTREAM-SOURCE-00000000N
->my-aggregation-repartition-source
Since these processors are stateless this is a non-breaking change
This PR should only get merged after the AK PR is merged to CCS.
Testing done
I ran
mvn clean package
against the branch with the Kafka Streams changes with updated expected topology files and tests for all modules passed.Reviewer checklist