Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Some further renaming/refactoring in function loading #3747

Merged
merged 1 commit into from
Nov 5, 2019
Merged

refactor: Some further renaming/refactoring in function loading #3747

merged 1 commit into from
Nov 5, 2019

Conversation

purplefox
Copy link
Contributor

@purplefox purplefox commented Nov 5, 2019 •
edited
Loading

Description

This PR does a bit of further refactoring around function loading, mainly in response to some previous review comments on #3690

This PR is a copy of #3713 which has been closed due to a corrupt Jenkins workspace

Testing done

Non functional change

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@purplefox purplefox requested a review from a team as a code owner November 5, 2019 13:50
@purplefox purplefox mentioned this pull request Nov 5, 2019
Closed
2 tasks
@purplefox purplefox merged commit 9c1a249 into confluentinc:master Nov 5, 2019
purplefox added a commit that referenced this pull request Nov 5, 2019
@purplefox
fix: Some renaming around KsqlFunction etc (#3747)
b30d965
@purplefox purplefox deleted the improve_func_invoking_10_new2 branch January 26, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@purplefox