feat: Implement complex expressions for table functions #3683
Conversation
| throw new IllegalArgumentException("Can't find input column " + columnName); | ||
| } | ||
| final Expression expression = functionCall.getArguments().get(0); | ||
| final ExpressionMetadata expressionMetadata = |
There was a problem hiding this comment.
I feel like this doesn't belong here - instead, we should be resolving all complex expressions before running the KudtfFlatMapper. This has a few benefits, the first is the performance benefit that I had mentioned earlier (we want to evaluate complex expressions once, not per every output row) and the second is that we're not treating arguments to UDTFs any differently than any other expression.
There was a problem hiding this comment.
Not sure I follow - this code is before the FlatMapper is run.
There was a problem hiding this comment.
Talked offline, because this PR is blocking lots of others I'm going to let it through as is and come up with a more detailed ticket describing what I mean by the comment.
purplefox
force-pushed
the
complex_select_1
branch
2 times, most recently
from
3852c7e to
3f9fe9a
Compare
purplefox
force-pushed
the
complex_select_1
branch
from
3f9fe9a to
95a325a
Compare
purplefox
force-pushed
the
complex_select_1
branch
from
138ffc7 to
8f182e3
Compare
Description
Fixes #3514
This is the 2nd PR in a stack. Please note this PR is stacked on #3685, so please don't review commits from the previous PR again.
With this PR table functions can now be arbitrarily complex expressions.
Testing done
New QTT test
Reviewer checklist