fix: fix parsing issue with LIST property overrides #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any config of type LIST would not be coerced properly by `KsqlRequest`. e.g. setting `set 'consumer.interceptor.classes'='io.confluent.monitoring.clients.interceptor.MonitoringConsumerInterceptor';` would see the value coerced to a LIST containing a single value of '[io.confluent.monitoring.clients.interceptor.MonitoringConsumerInterceptor]', rather than `io.confluent.monitoring.clients.interceptor.MonitoringConsumerInterceptor`. This commit resolves this issue. No other `ConfigDef.Type` should have a similar issue, as they are all single value.
purplefox
approved these changes
Oct 17, 2019
| @@ -124,10 +125,21 @@ public String toString() { | |||
|
|
|||
| private static Object coerceType(final String key, final Object value) { | |||
There was a problem hiding this comment.
MIght be nice to rename this coerceProperty or similar? It took me a while to figure out what it's doing, which would have been more obvious with a better name
There was a problem hiding this comment.
I'm ok with the name as-is, plus not added in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any config of type LIST would not be coerced properly by
KsqlRequest.e.g. setting
set 'consumer.interceptor.classes'='io.confluent.monitoring.clients.interceptor.MonitoringConsumerInterceptor';would see the value coerced to a LIST containing a single value of '[io.confluent.monitoring.clients.interceptor.MonitoringConsumerInterceptor]', rather than
io.confluent.monitoring.clients.interceptor.MonitoringConsumerInterceptor.This commit resolves this issue. No other
ConfigDef.Typeshould have a similar issue, as they are all single value.Testing done
mvn test
Reviewer checklist