Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Udf Invoker benchmark #3592

Merged
merged 1 commit into from
Oct 20, 2019
Merged

feat: Udf Invoker benchmark #3592

merged 1 commit into from
Oct 20, 2019

Conversation

purplefox
Copy link
Contributor

Description

This PR contains a new JMH benchmark for Udf invocations. It was created to compare before and after performance for #3566.

As this PR is stacked on #3566 it will contain the changes for that PR too, so please just review the file UdfInvokerBenchmark.java

Testing done

N/A

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@purplefox purplefox requested a review from a team as a code owner October 16, 2019 09:38
@purplefox purplefox mentioned this pull request Oct 16, 2019
Merged
2 tasks
big-andy-coates
big-andy-coates approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@big-andy-coates big-andy-coates left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @purplefox the test bit LGTM.

ksql-benchmark/src/main/java/io/confluent/ksql/benchmark/UdfInvokerBenchmark.java Outdated Show resolved Hide resolved
@purplefox purplefox merged commit 83dfc24 into confluentinc:master Oct 20, 2019
@purplefox purplefox deleted the invoker_benchmark2 branch October 20, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@big-andy-coates big-andy-coates big-andy-coates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purplefox @big-andy-coates