fix: Revert named stores in expected topologies, disable naming stores from StreamJoined, re-enable join tests. #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from StreamJoined, re-enable join tests.
bbejeck
changed the title
big-andy-coates
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Thanks @bbejeck - really appreciate you seeing this one through to the end!
Reverting the expected topologies ensures 5.4 goes out without a backwards incompatible change on internal topic and state store names.
Thanks!
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "tests": [ | |||
| { | |||
| "comment": "re-enable after KIP-479 is merged", | |||
| "enabled": false, | |||
| "comment": "Tests covering the use of Joins", | |||
There was a problem hiding this comment.
nit: would you mind just removing the comment and enabled fields from the JSON for each of these please?
|
@big-andy-coates updated this per comments |
|
Merged #3550 into master. |
|
Thanks @big-andy-coates and @agavra for the reviews! |
bbejeck
deleted the
fix_remove_with_store_name_method_revert_topologies_enable_join_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables the naming of stores in join operations and reverts the named stores in the expected topologies files. Note that in the future KSQL can easily re-enable the naming of state stores for joins. After this PR is merged, we should be able to close #3364
Testing done
Updated all expected topology files and ran all tests, everything passing.
Reviewer checklist