feat: add configurable MetricsReporter to MetricCollectors #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpyzhang
force-pushed
the
configurable-metrics-reporter
branch
2 times, most recently
from
fdccbf6 to
79911fa
Compare
rodesai
reviewed
Oct 7, 2019
ksql-common/src/main/java/io/confluent/ksql/metrics/MetricCollectors.java
Outdated
Show resolved
Hide resolved
ksql-common/src/test/java/io/confluent/ksql/metrics/MetricCollectorsTest.java
Outdated
Show resolved
Hide resolved
stevenpyzhang
force-pushed
the
configurable-metrics-reporter
branch
from
79911fa to
8a8663b
Compare
stevenpyzhang
force-pushed
the
configurable-metrics-reporter
branch
from
8a8663b to
041cd5f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows addition of MetricsReporters to MetricCollectors by specifying the type of reporter with the config "ksql.metric.reporters" and passing any other configs necessary to the server properties file. The corresponding MetricsReporter jar file must be specified in the ClassPath in order for this to work.
Testing done
Unit test
Reviewer checklist