fix: improve print topic error message when topic does not exist #3464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The message incorrectly stated that KSQL treats unquoted topic names as uppercase. This is not the case.
Also, the suggested alternative was just the opposite case to the supplied, which is fairly arbitrary, e.g. if the user issues
print PageView
and the topic does not exist the error message will suggestpAGEvIEW
, even though no such topic exists.With this change the error message will include any other topics that exist in the cluster with the same name, but different case.
New error message looks like:
Testing done
Test class switched from EasyMock to Mockito and suitable test added.
Reviewer checklist