Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3441): stabilize the StaticQueryFunctionalTest #3442

Conversation

big-andy-coates
Copy link
Contributor

Description

Fixes: #3441

Fix is to use different tmp directories per app. Two instances should not be using the same dir anyway.

Testing done

test-only change.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

Fixes: confluentinc#3441

Fix is to use different tmp directories per app.  Two instances should not be using the same dir anyway.
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agavra agavra requested a review from a team September 28, 2019 15:46
@big-andy-coates big-andy-coates merged commit 44ae3a0 into confluentinc:master Sep 29, 2019
@big-andy-coates big-andy-coates deleted the stabalize_static_func_test branch September 29, 2019 17:30
@vcrfxia
Copy link
Contributor

vcrfxia commented Sep 29, 2019

Thanks @big-andy-coates ! The fix feels so simple in hindsight, I'm embarrassed I didn't think of it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StaticQueryFunctionalTest on latest master is flaky
3 participants