feat(static): support ROWKEY in the projection of static queries #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesai
reviewed
Sep 28, 2019
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java
Outdated
Show resolved
Hide resolved
rodesai
reviewed
Sep 28, 2019
...ts/src/test/resources/rest-query-validation-tests/materialized-aggregate-static-queries.json
Show resolved
Hide resolved
Conflicting files ksql-functional-tests/src/test/resources/rest-query-validation-tests/materialized-aggregate-static-queries.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR you can now have
ROWKEYin the projection of a static query, e.g.This involves more hacking about in
StaticQueryExecutor, which will be refactored into something more manageable. Deadlines, deadlines!cc @derekjn , @MichaelDrogalis
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist