fix(3356): struct rewritter missed EXPLAIN #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSQL uses a statement rewritter to convert STRUCT field dereferences into `FETCH_FIELD_FROM_STRUCT` function calls. The rewrite is done for `Query`, `C*AS` and `INSERT INTO` statements, but was missing `EXPLAIN`. It is valid to execute `EXPLAIN` on a query string, e.g. `EXPLAIN SELECT address->street FROM Y;`. It is therefore important that the query within the `EXPLAIN` statement has the same rewrites applied to it as would be applied should the statement be executed directly.
2 tasks
vcrfxia
approved these changes
Sep 23, 2019
ksql-parser/src/main/java/io/confluent/ksql/parser/rewrite/StatementRewriter.java
Outdated
Show resolved
Hide resolved
Well, implied anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #3356
KSQL uses a statement rewritter to convert STRUCT field dereferences into
FETCH_FIELD_FROM_STRUCTfunction calls. The rewrite is done forQuery,C*ASandINSERT INTOstatements, but was missingEXPLAIN.It is valid to execute
EXPLAINon a query string, e.g.EXPLAIN SELECT address->street FROM Y;. It is therefore important that the query within theEXPLAINstatement has the same rewrites applied to it as would be applied should the statement be executed directly.Testing done
Suitable unit tests added.
Reviewer checklist