Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure default server config works with IP6 (fixes #3309) #3310

Merged
merged 12 commits into from
Sep 9, 2019
Merged

fix: ensure default server config works with IP6 (fixes #3309) #3310

merged 12 commits into from
Sep 9, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

Fixes #3309 by adding the IP6 equiv of http://0.0.0.0:8088 - the server will no listen on all IP6 interfaces too.

Testing done

Manual testing - can run server with just the IP6 listener and still connect using default CLI server of http://localhost:8088

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested review from JimGalasyn and a team as code owners September 6, 2019 19:24
JimGalasyn
JimGalasyn reviewed Sep 6, 2019
View reviewed changes
docs/operations.rst Outdated Show resolved Hide resolved
JimGalasyn
JimGalasyn reviewed Sep 6, 2019
View reviewed changes
docs/operations.rst Outdated Show resolved Hide resolved
JimGalasyn
JimGalasyn approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few suggestions.

vcrfxia
vcrfxia approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @big-andy-coates ! LGTM.

docs/installation/install-ksql-with-docker.rst Outdated Show resolved Hide resolved
config/ksql-server.properties Show resolved Hide resolved
docs/installation/server-config/config-reference.rst Outdated Show resolved Hide resolved
@vcrfxia vcrfxia requested a review from a team September 6, 2019 20:14
@vcrfxia vcrfxia changed the title fix(3309): ensure default server config works with IP6 fix: ensure default server config works with IP6 (fixes #3309) Sep 6, 2019
rodesai
rodesai approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

big-andy-coates and others added 11 commits September 8, 2019 22:22
@big-andy-coates @JimGalasyn
Update docs/installation/install-ksql-with-docker.rst
a2eb6fd 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update config/ksql-server.properties
e065ce1 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/installation/install-ksql-with-docker.rst
baccfa7 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/installation/install-ksql-with-docker.rst
438cfcf 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/installation/install-ksql-with-docker.rst
33e585f 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/installation/server-config/config-reference.rst
2957282 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/operations.rst
ba10941 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/troubleshoot-ksql.rst
ba4ee09 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/troubleshoot-ksql.rst
1647773 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates @JimGalasyn
Update docs/operations.rst
527ff73 
Co-Authored-By: Jim Galasyn <[email protected]>
@big-andy-coates
make docs clearer
277fe23
@big-andy-coates big-andy-coates merged commit 92b03ec into confluentinc:master Sep 9, 2019
@big-andy-coates big-andy-coates deleted the ip6 branch September 9, 2019 07:58
@stevenpyzhang stevenpyzhang mentioned this pull request Sep 9, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

@JimGalasyn JimGalasyn JimGalasyn approved these changes

@rodesai rodesai rodesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default server endpoint is incompatible with IPv6
4 participants
@big-andy-coates @rodesai @JimGalasyn @vcrfxia