Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused methods in SchemaUtil (MINOR) #3301

Merged
merged 1 commit into from
Sep 4, 2019
Merged

chore: remove unused methods in SchemaUtil (MINOR) #3301

merged 1 commit into from
Sep 4, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Sep 4, 2019

Description

removing unused methods - I'm trying to clean up usage around aliased fields

Testing done

ran SchemaUtilTest

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner September 4, 2019 16:33
vcrfxia
vcrfxia approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

spena
spena approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agavra agavra merged commit b5bc9ff into confluentinc:master Sep 4, 2019
@agavra agavra deleted the remove_su branch September 4, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agavra @spena @vcrfxia