Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve escaping of identifiers #3295

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Sep 3, 2019

Description

As part of the work around quoted identifiers, we need to be able to properly escape not just reserved words - but anything that doesn't parse as a proper identifier. I accomplished this by using the identifier rule to parse an identifier instead of trying to hack our own rules by creating the set of reserved words.

The new code is all in IdentifierUtil and I removed the old code in ParserUtil.

Testing done

  • unit testing
  • end to end tests after my implementation of quoted identifiers prototype

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner September 3, 2019 21:41
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, so we don't have to add reserved words in a Set.
LGTM

@spena spena requested review from spena and a team September 3, 2019 22:02
@agavra agavra merged commit 04435d7 into confluentinc:master Sep 3, 2019
@agavra agavra deleted the improve_reserved branch September 3, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants