fix: improve escaping of identifiers #3295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the work around quoted identifiers, we need to be able to properly escape not just reserved words - but anything that doesn't parse as a proper identifier. I accomplished this by using the
identifier
rule to parse an identifier instead of trying to hack our own rules by creating the set of reserved words.The new code is all in
IdentifierUtil
and I removed the old code inParserUtil
.Testing done
Reviewer checklist