Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message with DROP DELETE TOPIC is invalid #3279

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

spena
Copy link
Member

@spena spena commented Aug 27, 2019

Description

Fixes the following error message:

ksql> drop stream s2 delete topic;
Could not delete the corresponding kafka topic: s2
Caused by: Authorization denied to Delete on topic(s): [t2]

It used to display the topicName, and now displays the stream name. Now it is displayed as:

ksql> drop stream s2 delete topic;
Could not delete the corresponding kafka topic: t2
Caused by: Authorization denied to Delete on topic(s): [t2]

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena requested review from stevenpyzhang and a team August 27, 2019 22:31
@spena spena self-assigned this Aug 27, 2019
Copy link
Member

@stevenpyzhang stevenpyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, that was my change, thanks for the catch @spena ! LGTM (side note: would it be possible to add a unit test to check the content of the message?)

spena added 2 commits August 28, 2019 10:02
Instead of displaying the topic that cannot be deleted,
it shows the stream name
@spena spena force-pushed the fix_drop_delete_topic_error_msg branch from a32769a to b657b04 Compare August 28, 2019 15:02
@spena spena merged commit 4284b8c into confluentinc:master Aug 28, 2019
@spena spena deleted the fix_drop_delete_topic_error_msg branch August 28, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants