Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address deprecation of getAdminClient #3276

Merged
merged 1 commit into from
Aug 26, 2019
Merged

fix: address deprecation of getAdminClient #3276

merged 1 commit into from
Aug 26, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Aug 26, 2019

Description

Replace usage with getAdmin because KStreams deprecated getAdminClient

Testing done

mvn clean install

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner August 26, 2019 22:40
rodesai
rodesai approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vcrfxia
vcrfxia approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agavra !

@agavra agavra merged commit 6a50fca into confluentinc:master Aug 26, 2019
@agavra
Copy link
Contributor Author

agavra commented Aug 26, 2019

Merging to unblock build.

@agavra agavra deleted the fix_deprecation branch August 26, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

@rodesai rodesai rodesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agavra @rodesai @vcrfxia