Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix auth error message with insert values command #3257

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

spena
Copy link
Member

@spena spena commented Aug 22, 2019

Description

Fixes the INSERT VALUES authorization error message. It will now print something like this:

ksql> insert into t1(id) values (1);
Authorization denied to Write on topic(s): [t1]

Testing done

  • Added unit tests
  • Verified manually from CLI

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena added this to the 5.4 milestone Aug 22, 2019
@spena spena requested review from stevenpyzhang and a team August 22, 2019 20:03
@spena spena self-assigned this Aug 22, 2019
Copy link
Member

@stevenpyzhang stevenpyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spena , LGTM

@spena spena merged commit abe410a into confluentinc:master Aug 22, 2019
@spena spena deleted the fix_insert_values_auth_message branch August 22, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants