feat: format error messages better (MINOR) #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Aug 20, 2019
|
|
||
| // Then: | ||
| final String output = terminal.getOutputString(); | ||
| if (console.getOutputFormat() == OutputFormat.TABULAR) { |
There was a problem hiding this comment.
shouldn't this be an assertion? What if we have a bug where the output format is not TABULAR? This test will never fail.
There was a problem hiding this comment.
JSON is for the REST API, tabular is what the CLI displays - I think we need both. This test doesn't make sense for the JSON case because we don't do anything special for it (it's testing formatting in the CLI).
w.r.t the assertion, this test class runs all the tests first in JSON, then in TABULAR
There was a problem hiding this comment.
I see. I didn't notice this test is parameterized with JSON or TABULAR.
|
|
||
| // Then: | ||
| final String output = terminal.getOutputString(); | ||
| if (console.getOutputFormat() == OutputFormat.TABULAR) { |
There was a problem hiding this comment.
Same question as the previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do some pretty printing and wrapping to make sure that error messages aren't an eye sore.
Testing done
Before:
After:
Reviewer checklist