Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter null entries before creating KafkaConfigStore #3147

Merged
merged 1 commit into from
Jul 30, 2019
Merged

fix: filter null entries before creating KafkaConfigStore #3147

merged 1 commit into from
Jul 30, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Jul 30, 2019

Description

Our standalone module goes through KafkaConfigStore, which in turn uses ImmutableMap. The ImmutableMap requires all values in a map to be non-null. Since we added a few configurations with null defaults - we need to filter them out here.

Testing done

Updated tests to remove the filterNullEntries and manually spun up KSQL standalone.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra added the bug label Jul 30, 2019
@agavra agavra requested a review from a team as a code owner July 30, 2019 16:59
rodesai
rodesai approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vcrfxia
vcrfxia approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @agavra !

@agavra agavra merged commit 2852af1 into confluentinc:5.3.x Jul 30, 2019
@agavra agavra deleted the fix_null_map_entries branch July 30, 2019 18:15
@apurvam apurvam mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

@rodesai rodesai rodesai approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agavra @rodesai @vcrfxia