feat: Add window size for time window tables #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-time-window-tables
big-andy-coates
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Thanks @hjafarpour LGTM to me except from some code duplication.
ksql-functional-tests/src/main/java/io/confluent/ksql/test/model/WindowData.java
Outdated
Show resolved
Hide resolved
ksql-parser/src/main/java/io/confluent/ksql/parser/properties/with/CreateSourceProperties.java
Outdated
Show resolved
Hide resolved
ksql-parser/src/main/java/io/confluent/ksql/parser/properties/with/WithClauseProperties.java
Outdated
Show resolved
Hide resolved
ksql-parser/src/main/java/io/confluent/ksql/parser/properties/with/WithClauseProperties.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/test/java/io/confluent/ksql/ddl/commands/CreateStreamCommandTest.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/test/java/io/confluent/ksql/ddl/commands/CreateStreamCommandTest.java
Outdated
Show resolved
Hide resolved
ksql-parser/src/main/java/io/confluent/ksql/parser/properties/with/CreateSourceProperties.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when we specify
WINDOW_TYPEin a DDL statement to declare a table over a topic with WINDOWED key we need to provide the WINDOW_TYPE config property in the WITH clause. However, if the window is a time window, we user should also provide the size of the window, otherwise, the size will be the default, which isLong.MAX_VALUEwhich is incorrect.This PR introduces a new config property for DDL statements,
WINDOW_SIZEwhere if the window type is time window, user should provide the size using this parameter in the WITH clause of the DDL statement.Note that since the current behavior is incorrect anyway, we don't support backward compatibility here.
Also before we support this functionality we either have to have KIP-300 in kafka streams resolved or have a work around in KSQL for it.
Merging this PR won't have adverse effect on the current state anyway.
Testing done
Unit tests were added. QTT tests were updated accordingly.
Reviewer checklist