Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop describe topic functionality (MINOR) #3072

Merged
merged 2 commits into from
Jul 12, 2019
Merged

fix: drop describe topic functionality (MINOR) #3072

merged 2 commits into from
Jul 12, 2019

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Jul 12, 2019 •
edited
Loading

Description

In the CLI you can still do:

DESCRIBE TOPIC foo;

Which will only work if foo is a registered topic.

Registered topic functionality has been removed, but this functionality was missed - let's remove it.

Also see related #3068

Testing done

mvn test.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
fix: drop describe topic functionality
fd53fb6 
Registered topic functionality has been removed, but this was missed.
@big-andy-coates big-andy-coates requested a review from a team as a code owner July 12, 2019 12:17
@big-andy-coates big-andy-coates changed the title fix: drop describe topic functionality fix: drop describe topic functionality (MINOR) Jul 12, 2019
bluemonk3y
bluemonk3y approved these changes Jul 12, 2019
View reviewed changes
Copy link

@bluemonk3y bluemonk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@big-andy-coates big-andy-coates mentioned this pull request Jul 12, 2019
Merged
2 tasks
dguy
dguy approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@big-andy-coates big-andy-coates merged commit 1290b82 into confluentinc:master Jul 12, 2019
@big-andy-coates big-andy-coates deleted the describe_topic branch July 12, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemonk3y bluemonk3y bluemonk3y approved these changes

@dguy dguy dguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@big-andy-coates @dguy @bluemonk3y