perf: Remove parsing of integer literals #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old code converted INT and BIGINT literals to strings and then parsed them when processing every row. This adds unnecessary overhead to the row processing and so has been replaced with just the int/long value. Also improved error handling of numeric parsing: DOUBLEs now throw a parse exception if they result in NaN or Infinity and parse exceptions include correct location.
rodesai
reviewed
Jun 27, 2019
ksql-functional-tests/src/test/resources/query-validation-tests/literals.json
Show resolved
Hide resolved
ksql-parser/src/main/java/io/confluent/ksql/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
|
Why no green tick @rodesai ? I'm going to assume you meant to give one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing another PR I noticed that the code in the
SqlToJavaVisitorconverted INT and BIGINT literals to strings and then built java code that would parse these strings when processing each row of data. This adds unnecessary overhead to the row processing and so has been replaced with just the int/long value.Also improved error handling of numeric parsing: DOUBLEs now throw a parse exception if they result in NaN or Infinity and parse exceptions include correct location.
Testing done
Added QTT test
mvn testReviewer checklist