Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ksql topic name instead of Kafka topic name in topic map in met… #2149

Merged

Conversation

hjafarpour
Copy link
Contributor

@hjafarpour hjafarpour commented Nov 14, 2018

…astore.

This was cherry picked commit. (git cherry-pick 6baf263)
This PR brings back the commit( #1713 ) that was removed because of a bad merge.
Also needed to refactor a test.
This also fixes #2146

@hjafarpour hjafarpour requested a review from a team as a code owner November 14, 2018 00:26
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Will this fix #2146 ?

Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants