Added stringtodate and datetostring UDFs for 5.1.x #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2018 13:04
confluentinc#1851) Added stringtodate and datetostring UDFs (confluentinc#1851)
|
@confluentinc It looks like @andybryant just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
Hi @big-andy-coates. This is #1890 cherry picked for the 5.1.x branch Cheers |
2 tasks
|
@confluentinc/ksql can we get another +1 on this so that we can merge it? Has already been merged on master, but would be good to get this into 5.1... |
JimGalasyn
approved these changes
Oct 16, 2018
|
thanks @andybryant! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
stringtodateanddatetostringUDFs to convert to and from a formatted date string and an integer representing days since epoch. This format is used by Kafka Connect to represent Date objects with no time or time zone component.In a separate commit on the same PR I also updated
stringtotimestampandtimestamptostringto use the new UDF api and to support dynamically supplied format patterns.This is #1890 cherry picked for the 5.1.x branch.
Testing done
Added tests for all new functionality and ran locally. Generated and views updated docs locally.
Reviewer checklist