Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display stats timestamps in unambiguous format. #2018

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Display stats timestamps in unambiguous format. #2018

merged 3 commits into from
Oct 9, 2018

Conversation

big-andy-coates
Copy link
Contributor

Description

Switch the format for the timestamp on statistics to be unambiguous. Output is now:

Local runtime statistics
------------------------
...    last-message: 2018-10-06T16:17:17.782Z

Fixes #2002

Testing done

Added test.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner October 6, 2018 16:18
@big-andy-coates big-andy-coates requested a review from rmoff October 6, 2018 16:18
rmoff
rmoff approved these changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@rmoff rmoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ love it 📆 🕐

apurvam
apurvam approved these changes Oct 7, 2018
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@big-andy-coates big-andy-coates merged commit 3f8eff1 into confluentinc:master Oct 9, 2018
@big-andy-coates big-andy-coates deleted the unambiguous_time branch October 9, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoff rmoff rmoff approved these changes

@apurvam apurvam apurvam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@big-andy-coates @apurvam @rmoff