Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Remove duplicate junit dependency in ksql-examples #1997

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Oct 3, 2018

Description

At some point a second copy of the dependency on junit was introduced, which causes mvn warnings at the start of build. This just removes the extra copy.

Testing done

Tests run as usual.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@ewencp ewencp requested a review from a team October 3, 2018 17:14
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ewencp ewencp force-pushed the remove-duplicate-junit branch from 11508be to fdd1154 Compare October 4, 2018 00:35
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewencp ewencp force-pushed the remove-duplicate-junit branch 2 times, most recently from dd75604 to c2d8690 Compare October 5, 2018 20:08
@ewencp ewencp force-pushed the remove-duplicate-junit branch from c2d8690 to ae8645f Compare October 5, 2018 22:35
@ewencp ewencp merged commit 05b969f into confluentinc:master Oct 5, 2018
@ewencp ewencp deleted the remove-duplicate-junit branch October 5, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants