Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Improve test output for QueryTranslationTest #1992

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Minor: Improve test output for QueryTranslationTest #1992

merged 2 commits into from
Oct 5, 2018

Conversation

big-andy-coates
Copy link
Contributor

Description

  • Include test file name in test name, (so that tests from same file are grouped together)
  • Include output row that failed in test.
  • Refactor common code into single place.

Testing done

It's test code thats changed.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
- Include test file name in test name, (so that tests from same file …
b2f509d 
…are grouped together)

- Include output row that failed in test.
- Refactor common code into single place.
@big-andy-coates big-andy-coates requested a review from a team as a code owner October 3, 2018 11:48
@big-andy-coates big-andy-coates changed the title Improve test output for QueryTranslationTest Minor: Improve test output for QueryTranslationTest Oct 3, 2018
dguy
dguy approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@big-andy-coates big-andy-coates merged commit b4d4e02 into confluentinc:master Oct 5, 2018
@big-andy-coates big-andy-coates deleted the add_filename_to_tests branch October 5, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguy dguy dguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @dguy