Refactor KsqlParser #1775
Merged
Refactor KsqlParser #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
requested review from
dguy,
apurvam,
rodesai,
hjafarpour and
a team
dguy
approved these changes
Aug 24, 2018
| final Pair<String, PlanNode> statementPlanPair = logicalPlans.get(i); | ||
| if (statementPlanPair.getRight() == null) { | ||
| final Statement statement = statementList.get(i).getRight(); | ||
| final LogicalPlanNode statementPlanPair = logicalPlans.get(i); |
There was a problem hiding this comment.
nit: maybe a better name for the variable?
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While investigating how the parser worked and the different steps used to parse statements and build the AST I noticed that the code was in need of a refactor. So this PR does just that. Main class to change is
KsqlParser. I've tried to remove duplication from clients ofKsqlParserand improve encapsulation, (so, for example, the struct re-write is only done in one place now).When reviewing, I'd first look at
KsqlParser.Testing done
Ran tests.
Reviewer checklist