Switch the default mode of SUBSTRING to be the 'legacy' mode #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, so as not to be a breaking change. Original code change is in confluentinc#1635.
JimGalasyn
reviewed
Aug 14, 2018
docs/syntax-reference.rst
Outdated
| | | | by setting | | ||
| | | | **Deprecated**: As of version 5.1 of KSQL the | | ||
| | | | above version of ``SUBSTRING``is deprecated. | | ||
| | | | Please set | |
There was a problem hiding this comment.
Usually, we don't want to use the word "please" in docs. :)
JimGalasyn
approved these changes
Aug 14, 2018
…tes/ksql into default_substring_to_legacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW Description
Rather than switching the default mode of SUBSTRING to be legacy, as this PR originally intended, it now just leaves it as it was, (defaulting to the new mode), as per discussion here: #1682 (comment)
This PR now just contains some tidy up and test changes.
OLD Description
Testing done
Unit / functional.
Reviewer checklist