Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated join syntax to the syntax reference #1675

Merged
merged 3 commits into from
Aug 1, 2018

Conversation

apurvam
Copy link
Contributor

@apurvam apurvam commented Jul 31, 2018

Description

Update syntax reference to include the new join syntax.

Testing done

None. Docs only.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@apurvam apurvam requested review from JimGalasyn and a team July 31, 2018 23:43
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will be helpful!

Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apurvam apurvam merged commit fe9da5a into confluentinc:5.0.0-post Aug 1, 2018
@apurvam apurvam deleted the add-join-syntax branch August 1, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants