Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksqldb CLI should use ksqlDB prompt #4071

Open
rmoff opened this issue Dec 6, 2019 · 6 comments
Open

ksqldb CLI should use ksqlDB prompt #4071

rmoff opened this issue Dec 6, 2019 · 6 comments

Comments

@rmoff
Copy link
Member

rmoff commented Dec 6, 2019

ksqlDB 0.6

The ksql> prompt should be ksqlDB>

@agavra
Copy link
Contributor

agavra commented Dec 6, 2019

cc @derekjn - @rmoff, we had discussed this and decided to remain with ksql>. If we think of ksql as the language of ksqlDB, then it's okay and it doesn't have the extra chars (similarly to how postgres command is psql, not postgresDB)

@rmoff
Copy link
Member Author

rmoff commented Dec 6, 2019

Are you saying we don't want to change the prompt? Or we're just saying that it's ok as it is for the moment with the reasoning given

If we think of ksql as the language of ksqlDB

@rmoff
Copy link
Member Author

rmoff commented Dec 6, 2019

the two extra DB characters aren't going to break the bank. We'll save on screen pixel energy use from having ksql in lowercase instead of uppercase too ;-) ;-)

@derekjn
Copy link
Contributor

derekjn commented Dec 6, 2019

@rmoff we don’t plan to change the prompt. The issue is that it becomes a slippery slope: do we also change config parameter names? Do we change every occurrence of “ksql”? And would the resulting disruption be worth it to users?

As @agavra alluded to, it’s very common for a system like this to have a long and short name. e.g. Mongo/MongoDB, Postgres/PostgreSQL, etc., and in our case I don’t think that doing this meaningfully detracts from the UX.

@blueedgenick
Copy link
Contributor

blueedgenick commented Dec 6, 2019 via email

@derekjn
Copy link
Contributor

derekjn commented Dec 6, 2019

Personal favorite is the way SQLServer sets the
prompt to be the name of the schema you are in but we don't have that
concept yet

This is a great way to use the prompt and is what Postgres does as well (prompt is the name of the database you're connected to). Introducing a schema/namespace abstraction is on our radar: #3966.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants