Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull queries: Error in SELECT when ROWKEY contains the string null #3617

Closed
vpapavas opened this issue Oct 17, 2019 · 2 comments · Fixed by #3647
Closed

Pull queries: Error in SELECT when ROWKEY contains the string null #3617

vpapavas opened this issue Oct 17, 2019 · 2 comments · Fixed by #3647
Labels

Comments

@vpapavas
Copy link
Member

Describe the bug
Assume a table with schema:
ROWTIME|ROWKEY|METRICS_NAME |CLUSTER|TOPIC_NAME|ENV|AVG_VALUE

Assume the table contains the following two rows:
|1571347727133 |fetch_latency_ms|+|null|+|null|+|staging : Window{start=1571347680000 end=-}|fetch_latency_ms|null|null|staging|9.44924| |1571347727133 fetch_latency_ms|+|cluster_lmn|+|topic_2|+|staging : Window{start=1571347680000 end=-} |fetch_latency_ms |cluster_lmn |topic_2 |staging| 7.988785

Note how the key contains the string null in the first row.

Issue query:
select * from metrics_table where rowkey='fetch_latency_ms|+|null|+|null|+|null';
Error reported:
Server Error

To Reproduce
Steps to reproduce the behavior, include:

  1. The version of KSQL.
    Master
  2. Sample source data.
    Provided above
  3. Any SQL statements you ran
    Provided above

Expected behavior
Support rowkeys that contain the null string

Actual behaviour
A clear and concise description of what actually happens, including:

  1. CLI output
    Server Error
  2. Error messages
    Server Error
  3. KSQL logs
    ksql-cli logs contain:
    [2019-10-17 15:47:15,556] ERROR Server Error (io.confluent.ksql.cli.console.Console:323)

Additional context
Add any other context about the problem here.

@vpapavas vpapavas added the bug label Oct 17, 2019
vpapavas added a commit to vpapavas/ksql that referenced this issue Oct 22, 2019
@purplefox
Copy link
Contributor

Hi @vpapavas I am trying to understand what the '+' symbols represent in the example row:

|1571347727133 |fetch_latency_ms|+|null|+|null|+|staging : Window{start=1571347680000 end=-}|fetch_latency_ms|null|null|staging|9.44924|

Are you missing a '|' ?

vpapavas added a commit to vpapavas/ksql that referenced this issue Nov 3, 2019
vpapavas added a commit that referenced this issue Nov 3, 2019
@vpapavas
Copy link
Member Author

vpapavas commented Nov 7, 2019

Hey @purplefox !

Sorry I just saw your message.

This is how Ksql currently represents keys that consist of multiple columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants