Skip to content

Commit

Permalink
Flaky test (#3941)
Browse files Browse the repository at this point in the history
* test: fix flaky test

Test was failing because the pull query was return heads, but no row, but this was enough to pass the `assertThatEventually` line.  But this line should actually of been waiting of the store to return the value.
  • Loading branch information
big-andy-coates authored Nov 21, 2019
1 parent b7f75e4 commit 217c9ec
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ksql-cli/src/test/java/io/confluent/ksql/cli/CliTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ public void shouldHandlePullQuery() {
};

// Wait for warm store:
assertThatEventually(runner, containsString("ROWKEY"));
assertThatEventually(runner, containsString("|ITEM_1"));
assertRunCommand(
"SELECT * FROM X WHERE ROWKEY='ITEM_1';",
containsRows(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
/*
* Copyright 2019 Confluent Inc.
*
* Licensed under the Confluent Community License (the "License"); you may not use
* this file except in compliance with the License. You may obtain a copy of the
* License at
*
* http://www.confluent.io/confluent-community-license
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/

package io.confluent.ksql.execution.streams;

import static org.hamcrest.Matchers.equalTo;
Expand All @@ -12,13 +27,12 @@
import io.confluent.ksql.GenericRow;
import io.confluent.ksql.execution.codegen.ExpressionMetadata;
import io.confluent.ksql.execution.expression.tree.FunctionCall;
import io.confluent.ksql.name.ColumnName;
import io.confluent.ksql.name.FunctionName;
import io.confluent.ksql.schema.ksql.ColumnRef;
import io.confluent.ksql.logging.processing.ProcessingLogConfig;
import io.confluent.ksql.logging.processing.ProcessingLogMessageSchema;
import io.confluent.ksql.logging.processing.ProcessingLogMessageSchema.MessageType;
import io.confluent.ksql.logging.processing.ProcessingLogger;
import io.confluent.ksql.name.ColumnName;
import io.confluent.ksql.name.FunctionName;
import java.util.Collections;
import java.util.function.Function;
import org.apache.kafka.connect.data.SchemaAndValue;
Expand Down

0 comments on commit 217c9ec

Please sign in to comment.