Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate topic creation #488

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

rondagostino
Copy link
Member

Return TOPIC_ALREADY_EXISTS if an attempt is made to create a topic with a name that already exists.

Appended a few lines to existing create-topic test to try creating the same topic a second time and confirming that we get the expected error; the test failed prior to the fix and succeeded with it. Augmented streams_smoke_test.py system test to use both Zookeeper and Raft quorums; the Raft quorum cases were flaky before the fix and reliably passed with the fix.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@cmccabe
Copy link
Member

cmccabe commented Jan 19, 2021

LGTM. Thanks, @rondagostino !

@cmccabe cmccabe merged commit 3522a2b into kip-500 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants