[CCDB-4843] Register TimestampConverter in DebeziumLogicalConverters behind a config for BigQuerySink Connector #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp-gupta
force-pushed
the
CCDB-4843
branch
5 times, most recently
from
3fe951d
to
6fa2289
Compare
b-goyal
requested changes
Mar 15, 2023
kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/config/BigQuerySinkConfig.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/wepay/kafka/connect/bigquery/convert/BigQueryRecordConverter.java
Show resolved
Hide resolved
I think this issue can happen for a customer in CP with the same configs in future. I was thinking, we make this change once and for all. |
…behind a config for BigQuerySink Connector
|
Thought it got introduced in 2.3.x, if it is there in 1.6.x, we should target 1.6.x |
b-goyal
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…behind a config for BigQuerySink Connector
Refer to this ticket for details related to testing and Release Plan