Update pom.xml #1139
Open
Update pom.xml #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. Thanks for the examples. I am not 100% sure, but I suppose the log4j bugs are what caused these changes. This tutorial: https://docs.confluent.io/platform/current/schema-registry/schema_registry_onprem_tutorial.html#create-the-transactions-topic does not seem to work with the existing pom.xml as the log4j packages moved / versioned. I am actually not sure why the confluent-log4j worked only with a version being set (instead of just taking the latest, maybe a Maven pro can confirm). Thanks again.
davetroiano
requested changes
Nov 1, 2022
| </dependency> | ||
| <!-- Use a repackaged version of log4j with security patches. Default log4j v1.2 is a transitive dependency of slf4j-log4j12, but it is excluded in common/pom.xml --> | ||
| <dependency> | ||
| <groupId>io.confluent</groupId> | ||
| <artifactId>confluent-log4j</artifactId> | ||
| <version>1.2.17-cp10</version> |
There was a problem hiding this comment.
you should be able to remove the confluent-log4j dependency and use this instead:
<dependency>
<groupId>ch.qos.reload4j</groupId>
<artifactId>reload4j</artifactId>
<version>${reload4j.version}</version>
</dependency>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thanks for the examples. I am not 100% sure, but I suppose the log4j bugs are what caused these changes.
This tutorial:
https://docs.confluent.io/platform/current/schema-registry/schema_registry_onprem_tutorial.html#create-the-transactions-topic
does not seem to work with the existing pom.xml as the log4j packages moved / versioned. I am actually not sure why the confluent-log4j worked only with a version being set (instead of just taking the latest, maybe a Maven pro can confirm).
Thanks again.
Description
What behavior does this PR change, and why?
Author Validation
Describe the validation already done, or needs to be done, by the PR submitter.
Reviewer Tasks
Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.