Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANSIENG-4314] | Adding check sub property role for testing comma seperated list of values #1869

Open
wants to merge 4 commits into
base: 7.8.x
Choose a base branch
from

Conversation

rrbadiani
Copy link
Member

Description

In a couple of test cases we had a check to confirm the value of sasl.enabled.mechanisms is set to GSSAPI,PLAIN but it could also have been set to PLAIN,GSSAPI. so instead of doing a string matching of values we can parse the value and split by comma and make a list. Then compare items of list to ensure all the mechanisms which should be present are actually present.

This will help remove flakiness as at times this property would be set to GSSAPI,PLAIN and at other times it would be PLAIN,GSSAPI both of which are same from cp point of view.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Semaphore link - [add here]

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

…erated list of values present corresponding to a key in properties files
@rrbadiani rrbadiani requested a review from a team as a code owner December 30, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant