Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new variable to control Kafka URP topics retries #1868

Open
wants to merge 1 commit into
base: 7.8.x
Choose a base branch
from

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Dec 30, 2024

Description

This PR makes it possible to configure the number of retries while waiting for URP topics to stabilize during Kafka health checks.

We are using the health checks tasks when OS-patching our clusters. For some major patches that require a node reboot, a restarted broker needs more time to catch up on replicating partitions. With the current settings, this fails the play, which also wastes a lot of resources on fetching log files for troubleshooting (not required). We think the number of retries while waiting for URP topics to stabilize should be configurable - as it will depend on the cluster load.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@erikgb erikgb requested a review from a team as a code owner December 30, 2024 11:31
@erikgb
Copy link
Contributor Author

erikgb commented Dec 30, 2024

Please advice which branch to target for this PR. We are currently using the v7.7.2 tag, but 7.8.0 seems to be your latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant