Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANSIENG-4314] | adding retries for verify task to authenticate to c3 via sso #1857

Open
wants to merge 1 commit into
base: 7.6.x
Choose a base branch
from

Conversation

rrbadiani
Copy link
Member

@rrbadiani rrbadiani commented Dec 12, 2024

Description

Molecule tests which setup C3 with SSO are a bit flaky in the task Check status of Authenticate api

This task is present in verify.yml files. The reason for flakiness is C3 takes little more time to start when it has SSO. And verify.yml runs before C3 actually starts.

To fix this issue adding sleep of 1 minute before running the Check status of Authenticate api was good enough to make these tests pass. So instead of using sleep we added retries where it retries for 2 minutes until this authenticate status is okay.

Making this change will impact the following scenarios

  • rbac-mtls-rhel8 (Very very flaky)
  • rbac-mds-plain-custom-rhel-fips (little flaky)
  • rbac-mds-kerberos-debian (little flaky)
  • rbac-scram-custom-rhel-fips (little flaky)

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

zk
kraft

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@rrbadiani rrbadiani requested a review from a team as a code owner December 12, 2024 04:11
Copy link
Contributor

@mansi-jain-1206 mansi-jain-1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants