-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "sasl_protocol: oauthbearer" which does not add default handlers #1093
base: 7.1.x
Are you sure you want to change the base?
Add "sasl_protocol: oauthbearer" which does not add default handlers #1093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we could consider a separate PR to catch up the missing re-gen of md-files.
09538ac
to
d4c4e90
Compare
d4c4e90
to
b9f0f12
Compare
'io.confluent.kafka.server.plugins.auth.token.TokenBearerServerLoginCallbackHandler' | ||
final_dict['listener.name.' + listener_name + '.oauthbearer.sasl.jaas.config'] =\ | ||
'org.apache.kafka.common.security.oauthbearer.OAuthBearerLoginModule required publicKeyPath=\"' + oauth_pem_path + '\";' | ||
if listeners_dict[listener].get('sasl_protocol', default_sasl_protocol).upper() == 'OAUTH': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not update this condition to check the property confluent_server_enabled
That way probably we don't need to add another mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does there need to be 2 if statements
if self.normalize_sasl_protocol(listeners_dict[listener].get('sasl_protocol', default_sasl_protocol)) == 'OAUTHBEARER':
if listeners_dict[listener].get('sasl_protocol', default_sasl_protocol).upper() == 'OAUTH':
86a143d
to
c34cf2c
Compare
Description
Using the existing
sasl_protocol: oauth
will add callback handlers for Confluent-provided classes. This PR adds a similarsasl_protocol: oauthbearer
that will not automatically set up any callback handlers.Fixes #1089
Type of change
How Has This Been Tested?
Molecule test, and test in our local cluster.
Test Configuration:
Checklist: