-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for Travis CI #39
Conversation
Ping @domibarton, @chadmandoo. It would be great to have your feedback. |
397339e
to
fe9f080
Compare
e03d5d9
to
352b0cf
Compare
I think we can finally merge this PR as is, and let the missing features for other PR in order to keep the responsibilities separated (maybe some of them should wait for a next major). /cc @domibarton, @ojgarciab, @nesies, @n4huel. |
We can't run tests against a running The work is done in my own fork. I'll create a PR when this PR is merged.
PS: continuous-integration/travis-ci/pr is deprecated since October 4th, 2018, you need to change it to Travis CI - Pull Request. |
Great improvement! About the Travis integration, I think we can wait for the automatic migration. At least, I didn't found a procedure to execute the migration for open source repos.
|
This PR is a work in progress, please do not merge yet.
For an example of CI result, see my build at https://travis-ci.org/phansys/PhpZabbixApi/builds/295154153.
I'm proposing to re-pack the build result into this repo, since it is intended to be used as an SDK for Zabbix API; so this library must act as a client independent from the Zabbix server / frontend.
The build will be kept as responsible of code generation, as you can see at the build matrix. The repo must have a branch in parallel with the Zabbix minor versions (
2.0
,2.1
,2.2
, ...) in order to guarantee BC while respecting semantic versioning.This PR is based on 2.4 version, so the build matrix executes the tests against the first release (
2.4.0
) and against the latest release (2.4.8
), in order to ensure there are no differences through patch releases. Please note this check is performed executing the build and confirming there are no differences with the existent code (withgit diff
).In this PR the autoload mechanism was upgraded too, from
classmap
topsr-4
.TODO:
Please, be free to share any thoughts or comments.