Adding current system user to auth file token name #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases php processes use same zabbix user to auth, but execute under different system users (shell, apache). So they will use the same auth file, but only the first will gain access. And the second process with different user will never use cached token. So token file should be unique for different system users.
|
One more improvement - add separator between zabbix user and system for univocacy: |
|
Faced that issue too, I was about to submit a pull request when saw this one, this definitely needs to be merged in ;-) |
|
Sorry for the delay :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Dominique. Thank You for library. Very useful for me. I have a proposal to fix one problem.
In some cases php processes use same zabbix user to auth, but execute under different system users (shell, apache). So they will use the same auth file, but only the first will gain access. And the second process with different user will never use cached token. So token file should be unique for different system users.
Please aprove my change.
If I'm not mistaken it needs to rebuild new versions? What is sequence of actions to rebuild it for both 2.2 and 2.4 branches? Who should do it?