Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract queries pagination cont'd #204

Merged
merged 7 commits into from
Dec 14, 2021
Merged

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Dec 7, 2021

Closes the 2nd part of #88 (query members, query members by weight).

TODO:

  • Use specific pagination struct instead of query.PageRequest. (done)
    • Add checks for / errors if PageRequest Offset and CountTotal are set. (done)
  • QueryTG4Member* unit tests.
  • QueryTG4Member* integration tests. (done)

@maurolacy maurolacy force-pushed the 88-contract-queries-pagination-2 branch from cca9bea to be7cf79 Compare December 9, 2021 09:11
@maurolacy maurolacy force-pushed the 88-contract-queries-pagination-2 branch from 1595ae4 to 717c5d5 Compare December 10, 2021 14:52
@maurolacy maurolacy force-pushed the 88-contract-queries-pagination-2 branch from 717c5d5 to 5f5ee97 Compare December 10, 2021 14:53
@maurolacy maurolacy merged commit b740866 into main Dec 14, 2021
@maurolacy maurolacy deleted the 88-contract-queries-pagination-2 branch December 14, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant