Implement [e2e-d08]valWithdrawRewardsAsDelegateToAnother.feature #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther-address # Conflicts: # cypress/integration/[d07]-valWithdrawRewardsAsDelegate.feature
Ebazhanov
commented
Sep 6, 2022
Comment on lines
52
to
56
| # TODO improve after getting more validator issues/789 | ||
| * I see TGD balance "0.1" | ||
| * I close wallet dialog modal | ||
| # TODO improve after getting more validator issues/789 | ||
| * I use "randomMnemonic07" to make query and check balance of this address "0" |
There was a problem hiding this comment.
I know this is not an accurate and not a good solution but we are going to improve it after I get more validator with Rewards
#789
Ebazhanov
commented
Sep 6, 2022
Comment on lines
82
to
85
| # TODO improve after getting more validator issues/789 | ||
| * I see TGD balance "0" | ||
| * I close wallet dialog modal | ||
| # TODO improve after getting more validator issues/789 |
Ebazhanov
commented
Sep 6, 2022
| @@ -16,7 +16,7 @@ Given("Go to Trusted Circle page", () => { | |||
|
|
|||
| When("I click on Add Trusted Circle button", () => { | |||
| cy.url().should("not.include", "/trustedcircle/undefined"); //probably a bug of the App | |||
| cy.findByText(/Add Trusted Circle/i).click(); | |||
| cy.get('[data-cy="trusted-circle-page-add-trusted-circle-button"]').click(); | |||
There was a problem hiding this comment.
i hope it will help to prevent it
also did some related adjustments in this PR
FYI 30b30ef
|
Maybe we should wait to merge #832 before and then adapt this one to auto code ID |
i am fine, will just clone this branch for my next task |
abefernan
approved these changes
Sep 6, 2022
…ther-address # Conflicts: # cypress/steps-definition/TrustedCircles.ts
…ther-address # Conflicts: # src/__tests__/integration/happy-paths/trustedCircle.test.ts
…ther-address # Conflicts: # cypress/integration/[a01]-tgdBalance.feature # cypress/integration/[a04]-sendTgd.feature # cypress/integration/[c03]-withdrawRewardsAsDelegate.feature # cypress/integration/[d05]-valWithdrawMyRewards.feature # cypress/integration/[d06]-valWithdrawMyRewardsToAnother.feature # cypress/integration/[d07]-valWithdrawRewardsAsDelegate.feature # cypress/steps-definition/ConnectWalletModal.ts # cypress/steps-definition/MainNavigationMenu.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #827