-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Update payloads for v0.10.0 #448
Release: Update payloads for v0.10.0 #448
Conversation
Update the enclave-cc runtime payloads to point to the v0.10.0 release of enclave-cc and update the pre-reqs payload. Signed-off-by: Niteesh Dubey <[email protected]>
ad57d3e
to
429a9de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @niteeshkd!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. I sanity checked it by comparing against the same step for v0.9.0 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still seems to be an issue with the kata version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It generally looks good, there is the v3.9.0
vs. 3.9.0
issue introduced in the 2nd commit and fixed in the 3rd one which needs to be corrected (so changes work separately).
One more thing I noticed is that there are still a couple of 3.9.0
entries here and there, shouldn't these be tackled together? {Makefile,config/manager/kustomization.yaml,config/manifests/bases/cc-operator.clusterserviceversion.yaml,bundle/manifests/cc-operator.clusterserviceversion.yaml}
I looked at the files you pointed to, and I guess you mean the Edit: This is Step 8 for us currently. |
Update Kata payloads to 3.9.0 and bump the pre-reqs payload for default, peer-pods and s390x ccruntimes Signed-off-by: Niteesh Dubey <[email protected]>
Update operator version from v0.9.0 to v0.10.0. Signed-off-by: Niteesh Dubey <[email protected]>
429a9de
to
3b97c90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have treated these as a later step in the past. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we did some manual testing too and seems working
Yes, those are the changes required for publishing the released operator in operator hub. The instructions are in here but I think it's a good idea to merge the steps into this doc, all in all, it's part of the release. I don't know if step 8 could also be done simultaneously with step 5 (this). The bundle generated bundle files will point to the built operator image ( For 0.10.0 release, maybe let's not change the flow.
|
I guess there is a nonzero chance of v0.10.1 so I will wait to tag the repo. |
No description provided.