Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh action updates #436

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Sep 4, 2024

manual upgrades from #431 and #432.

potentially interesting read https://pin-gh-actions.kammel.dev/

Rationale:
Not because of being paranoid but mainly because it's considered a good security practice. That practice is also checked by tools like OpenSSF Scorecard so if our repos are benchmarked using that common tooling, it shows we are "compliant".

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not convinced it increases the security significantly enough compare to what we'll have to investigate in reviewing those patches. But if we agree to simply merge whatever dependabot produces and provided we make the checks monthly it should be bearable.

Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
to avoid PRs getting generated "all the time", move to a monthly
cadence for dependabot triggered github-actions updates.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi
Copy link
Contributor Author

mythi commented Oct 3, 2024

we make the checks monthly it should be bearable

added a commit to make the cadence monthly. it's "on the first day of the month"

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ldoktor ldoktor merged commit b99a05b into confidential-containers:main Oct 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants