cdh: move image crate into hub/image module #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the image crate is used exclusively by cdh, so we don't need to maintain it as individual crate, helping with naming conflicts and reducing build complexity. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/rework-image-crate-as-cdh-module
branch
from
dd60574 to
16a316f
Compare
Xynnn007
approved these changes
Nov 20, 2024
mythi
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the image crate is used exclusively by cdh, so we don't need to maintain it as individual crate, helping with naming conflicts and reducing build complexity.
note: we want to do this more module-like crates like
kms, orsecret, but this can be done in individual PRs to keep.I think a good target picture would be a single crate for CDH w/ bin & lib, that can be consumed in other crates