Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prost/tonic/tonic-build deps #719

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Xynnn007
Copy link
Member

Close #698

@Xynnn007 Xynnn007 requested a review from a team as a code owner September 12, 2024 08:49
@Xynnn007
Copy link
Member Author

Xynnn007 commented Sep 12, 2024

Ok the failure comes from the rust toolchain version. See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script

tonic-build 0.12.2 cannot be built by rust toolchain lower that 1.77.0 while we are using 1.76.0 now. This is fixed by hyperium/tonic#1894 two weeks ago but that fix has not been included by a release of tonic-build. Let's wait for a new version of tonic-build and update this PR.

@Xynnn007
Copy link
Member Author

Use the latest tonic-build. Let's see if it passes CI

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkulke mkulke merged commit 17f9899 into confidential-containers:main Oct 2, 2024
15 checks passed
@Xynnn007 Xynnn007 deleted the chore-grpc-suites branch October 5, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants