SecureComms: Fix needed following changes in other components #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhadas
force-pushed
the
secComms_fix_for_0.10
branch
2 times, most recently
from
f298965 to
cd3c315
Compare
davidhadas
force-pushed
the
secComms_fix_for_0.10
branch
3 times, most recently
from
b4c8398 to
e82a59a
Compare
|
cc: @bpradipt |
This was referenced Oct 8, 2024
stevenhorsman
requested changes
Oct 8, 2024
davidhadas
force-pushed
the
secComms_fix_for_0.10
branch
from
e82a59a to
5679447
Compare
|
I've tried to test this code change and doc (creating CAA image quay.io/stevenhorsman/cloud-api-adaptor:dev-3fa7867a7499f2a636179f83c68174330812113d-dirty and podvm quay.io/stevenhorsman/podvm-generic-ubuntu-amd64:80da436ca39f40d439da987a3c83271f9dffb0ae3ac5dc9283a7ce8d6a112c97) and it doesn't work for me. The agent proxy never connected and times out after 5mins: Has anyone else successfully tested this - and tips for what I did wrong here? |
|
Did you follow the instructions to activate secure comms in SecureComms.md?
The Caa in your envirinment is not configured to activate SecureComms. You
can see this since caa is approaching 192.168.122.33:15150.
When the peerpod
ConfigMap is configured correctly, caa should approach 192.168.122.33:2222 instead. The proxy agent will later approach some local port instead of a peerpod port.
|
This is my peer-pod-cm: |
|
Ok, I've got it working. The doc doesn't mention that after editing |
davidhadas
force-pushed
the
secComms_fix_for_0.10
branch
from
5679447 to
d3c1eac
Compare
1. Trustee Operator had changed the namespace 2. CAA had removed the SecureComms default kbs address Use InitData to set the kbs address instead Signed-off-by: David Hadas <[email protected]>
davidhadas
force-pushed
the
secComms_fix_for_0.10
branch
from
d3c1eac to
c3d306c
Compare
|
SecureComms.md is now modified to include:
|
stevenhorsman
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
LGTM and the doc fixes should resolve the issues I hit when testing this. Thanks @davidhadas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the trustee operator namespace
Add necessary initData to get SecureComms to work