podvm: Update hardcoded value for oras on podvm-builder #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the ARCH value on podvm-builder, so that it can pick up the respective architecture while it's being built. Fixes confidential-containers#2059 Signed-off-by: Ajay Victor <[email protected]>
ajaypvictor
force-pushed
the
fix-oras-ref
branch
from
45b9a75 to
1733e9c
Compare
|
Given that we don't really want to dig into native s390x support for the ubuntu builder (as we build the s390x binaries image on top of the amd64 builder) and mkosi will replace it, so I've suggested to Ajay to just update the rhel builder for now (which IBM are building natively due to subscription requirements), so I don't think we need the libvirt e2e tests passing now as we don't build rhel anywhere upstream. |
stevenhorsman
approved these changes
Sep 25, 2024
bpradipt
merged commit 4cd4057
into
confidential-containers:main
27 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the ARCH value on podvm-builder, so that it can pick up the respective architecture while it's being built.
Fixes #2059